fix(no-node-access): support user-event instances returned from custom render#1048
Merged
Belco90 merged 5 commits intotesting-library:mainfrom Aug 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 96.46% 96.47% +0.01%
==========================================
Files 50 50
Lines 2687 2695 +8
Branches 1112 1111 -1
==========================================
+ Hits 2592 2600 +8
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
You're right — it looks like this does cover the cases from #1049, so I've added tests for them in a757b7e. |
Belco90
previously approved these changes
Jul 28, 2025
Member
Author
|
I added test in 71b22e7. |
Merged
1 task
1 task
georgios-goulos
added a commit
to camunda/camunda
that referenced
this pull request
Aug 1, 2025
## Description <!-- Describe the goal and purpose of this PR. --> The ESLint plugin was broken. There's a fix for it but it's not released yet: testing-library/eslint-plugin-testing-library#1048 ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [ ] Enable backports when necessary (fex. [for bug fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes) or [for CI changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)). ## Related issues closes #
Belco90
approved these changes
Aug 11, 2025
|
🎉 This PR is included in version 7.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Context
Fixes: Comments below
#1033 (review)